Optimize fuzzer by avoiding traversal of the whole configuration in term substitution #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbyalcinkaya
changed the title
automergerpr-permission-manager bot
added a commit
to runtimeverification/k
that referenced
this pull request
Mar 14, 2025
Replaces `top_down` with `bottom_up` to avoid redundant traversals in replacement terms, improving performance for large terms. While replacement terms are usually not large, this change enables an optimization in komet that results in a 3x speedup. The optimization in komet works by embedding large configuration cells without variables directly into a replacement term. This prevents the substitution algorithm from needlessly traversing these large terms, significantly reducing overhead. * runtimeverification/komet#69 Co-authored-by: automergerpr-permission-manager[bot] <190534181+automergerpr-permission-manager[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance by embedding large configuration cells without variables directly into a
Step. This prevents the substitution algorithm from needlessly traversing these large terms, leading to a 3x speedup in fuzzing.The speedup was measured using the existing test suite, particularly the FxDAO tests. In cases where the initial state is larger—such as tests involving multiple contracts or bigger contracts—the performance improvement is even more significant.
While this optimization is effective, a more robust solution would be to extend the
fuzzfunction from pyk with an optional parameter for custom substitution functions. This would allow direct manipulation of variables in the template without requiring a full tree traversal.