Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug causing beams to not be reordered by log probability. #86

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

daphnei
Copy link

@daphnei daphnei commented Mar 12, 2019

Previously, because beam_logprobs_sum[vix] is a pointer, line 120 would set it equal to -1000, causing the sort on line 126 to be meaningless (since every x['p'] would be -1000). I fix this by turning the tensor pointer into a float.

ruotianluo and others added 9 commits December 11, 2017 11:09
Add a reference to cheat some citations.
* saving to and loading from single hdf5

* fixed the indexing

* flak8

* fixed paralle

* changed function name

* updated pre_process_script

* fix for type

* code cleanup

* script added to convert old numpy files into h5 data
… we can directly use the loaded array size to create dataset);

remove prepro_process_script.sh
* Update to pytorch4.1

* Refactor
* Update to pytorch4.1

* Refactor

* Fix dataloader

* Change to item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants