Put a player cap on the lights out event to prevent it from running without people to fix the lights.#60
Open
DustanHache wants to merge 1 commit intoruss-money:mainfrom
Open
Put a player cap on the lights out event to prevent it from running without people to fix the lights.#60DustanHache wants to merge 1 commit intoruss-money:mainfrom
DustanHache wants to merge 1 commit intoruss-money:mainfrom
Conversation
Why do we allow lights out when whoever might be arriving isn't guaranteed to have a light?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Salt PR, mainly because I find it obnoxious to try and latejoin when the entire kingdom is in darkness. Between the color scheme and the day/night cycle, you will be blind for half of the round if the lights out event has fired at any point before people are around. This is detrimental both for RP and general gameplay.
Why It's Good For The Game
Being in the dark because your king died? great omen. Being in the dark because there was nobody to serve as king to begin with? Agony.