Stop displaying undefined values in side table of vcf-report (#145)

* Stop displaying undefined values in side table of vcf-report This fixes #144. * Update CHANGELOG.md Co-authored-by: Johannes Köster <[email protected]>
rust-bio · Apr 19, 2021 · 0688651 · 0688651
1 parent c957c81
commit 0688651
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,9 +3,10 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [0.20.5] - 2021-04-19
+### Changed
+- Bugfix for `rbt vcf-report` that stops displaying undefined values in the table-report.
 ### Added
-- New parameter `--pin-until` for `rbt csv-report`.
-- `--pin-until` pins the table until the given column such that scrolling to the right does not hide the given column and those before.
+- New parameter `--pin-until` for `rbt csv-report`. `--pin-until` pins the table until the given column such that scrolling to the right does not hide the given column and those before.
 
 ## [0.20.4] - 2021-04-15
 ### Changed

diff --git a/src/bcf/report/js/table-report.js b/src/bcf/report/js/table-report.js
@@ -83,29 +83,33 @@ $(document).ready(function () {
                 let ix = x + 1;
                 let field = 'ann[' + j + '][' + ix + ']';
                 let vl = $(that).data(field);
-                if (name === "Existing_variation" && vl) {
-                    let fields = vl.split('&');
-                    let result = "";
-                    for (var o = 0; o < fields.length; o++) {
-                        let val = fields[o];
-                        if (val.startsWith("rs")) {
-                            result = result + "<a href='https://www.ncbi.nlm.nih.gov/snp/" + val + "'>" + val + "</a>";
-                        } else if (val.startsWith("COSM")) {
-                            let num = val.replace( /^\D+/g, '');
-                            result = result + "<a href='https://cancer.sanger.ac.uk/cosmic/mutation/overview?id=" + num + "'>" + val + "</a>";
-                        } else if (val.startsWith("COSN")) {
-                            let num = val.replace( /^\D+/g, '');
-                            result = result + "<a href='https://cancer.sanger.ac.uk/cosmic/ncv/overview?id=" + num + "'>" + val + "</a>";
-                        } else {
-                            result = result + val;
-                        }
-                        if (!(o === fields.length - 1)) {
-                            result = result + ", ";
+                if (vl) {
+                    if (name === "Existing_variation") {
+                        let fields = vl.split('&');
+                        let result = "";
+                        for (var o = 0; o < fields.length; o++) {
+                            let val = fields[o];
+                            if (val.startsWith("rs")) {
+                                result = result + "<a href='https://www.ncbi.nlm.nih.gov/snp/" + val + "'>" + val + "</a>";
+                            } else if (val.startsWith("COSM")) {
+                                let num = val.replace( /^\D+/g, '');
+                                result = result + "<a href='https://cancer.sanger.ac.uk/cosmic/mutation/overview?id=" + num + "'>" + val + "</a>";
+                            } else if (val.startsWith("COSN")) {
+                                let num = val.replace( /^\D+/g, '');
+                                result = result + "<a href='https://cancer.sanger.ac.uk/cosmic/ncv/overview?id=" + num + "'>" + val + "</a>";
+                            } else {
+                                result = result + val;
+                            }
+                            if (!(o === fields.length - 1)) {
+                                result = result + ", ";
+                            }
                         }
+                        vl = result;
                     }
-                    vl = result;
+                    $('#ann-sidebar').append('<td>' + vl + '</td>');
+                } else {
+                    $('#ann-sidebar').append('<td></td>');
                 }
-                $('#ann-sidebar').append('<td>' + vl + '</td>');
             }
             $('#ann-sidebar').append('</tr>');
         });