-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: Update xlsxwriter due to compilation error with older version (#…
…257)
- Loading branch information
Showing
2 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ffaf4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fxwiegand May I ask you for a new release with this fix ?
The Bioconda build fails due to it - bioconda/bioconda-recipes#46802
If you don't plan a new release then I could apply it as a patch too!
Thank you!
0ffaf4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/rust-bio/rust-bio-tools/releases/tag/v0.42.1 - Thanks!
0ffaf4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem at all - the update on bioconda does seem to throw an error though. Would you wanna have a look into this?
0ffaf4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am looking at it at bioconda/bioconda-recipes#46802 !
I'll keep you posted !
0ffaf4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to update few dependencies to be able to build rbt on Linux ARM64: https://github.com/bioconda/bioconda-recipes/pull/46802/files#diff-95f8c720fddcb314cd6aed1a3b2bb937837e053c6d39e27fb014099bd6bdf622
I will open a PR for them!
bioconda/bioconda-recipes#46976 is a PR that just updates rbt (without enabling additional CPU architectures) and it goes well too!