Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add UPGMA, Neighbor-Joining, and RF-distance to cli tool #200

Closed

Conversation

RagnarGrootKoerkamp
Copy link
Contributor

@RagnarGrootKoerkamp RagnarGrootKoerkamp commented Nov 30, 2021

Depends on rust-bio/rust-bio#470

This adds CLI wrappers for the algorithms added in that PR.

I could move the code in main.rs into a separate module, but it's so small that's probably not worth it.

Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I think having a separate module with the API calls for the two methods would be nice in order to keep main.rs a bit cleaner, if you don't mind.

src/cli.rs Outdated Show resolved Hide resolved
@RagnarGrootKoerkamp
Copy link
Contributor Author

Done

@johanneskoester
Copy link
Contributor

There are some errors now.

@RagnarGrootKoerkamp
Copy link
Contributor Author

RagnarGrootKoerkamp commented Dec 1, 2021

Yes the errors are expected. We first need to merge the other PRs, and bump versions of rust-bio-types and rust-bio
rust-bio/rust-bio-types#35
rust-bio/rust-bio#468
rust-bio/rust-bio#469
rust-bio/rust-bio#470

@RagnarGrootKoerkamp
Copy link
Contributor Author

This was a small project that never went anywhere. I don't care for it anymore.
If someone wants to continue it feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants