Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update rust-htslib to 0.46.0 and GSL to 7.0.0 for Linux ARM64 compatibility #259

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Apr 5, 2024

@fxwiegand fxwiegand changed the title Update rust-htslib to 0.46.0 and GSL to 7.0.0 for Linux ARM64 compatibility build: Update rust-htslib to 0.46.0 and GSL to 7.0.0 for Linux ARM64 compatibility Apr 5, 2024
@fxwiegand
Copy link
Contributor

fxwiegand commented Apr 5, 2024

test_vcf_annotate_dgidb seems to fail in testing.

rust-bio-tools/tests/lib.rs

Lines 356 to 363 in 37e3dbe

#[test]
fn test_vcf_annotate_dgidb() {
let exec_test = Command::new("bash")
.arg("-c")
.arg("target/debug/rbt vcf-annotate-dgidb tests/annotate_dgidb_test.vcf | bcftools view - | wc -l").output()
.expect("failed to execute process");
assert!(exec_test.status.success());
assert_eq!(String::from_utf8(exec_test.stdout).unwrap().trim(), "65");

@martin-g
Copy link
Contributor Author

martin-g commented Apr 5, 2024

I'll take a look soon !

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Copy link
Contributor Author

martin-g commented Apr 5, 2024

I think I fixed the problem!
http://dgidb.org/api/v2/interactions.json returns 404. Now only HTTPS is supported.
But this means that also the old versions of rbt should be broken.

@fxwiegand fxwiegand merged commit 39d587d into rust-bio:master Apr 5, 2024
4 checks passed
@fxwiegand
Copy link
Contributor

I think I fixed the problem! http://dgidb.org/api/v2/interactions.json returns 404. Now only HTTPS is supported. But this means that also the old versions of rbt should be broken.

Thanks for digging into this! Yes indeed it seems weird that the test didn't fail in earlier releases.

@martin-g martin-g deleted the aarch64-compatibility branch April 5, 2024 12:20
@martin-g
Copy link
Contributor Author

martin-g commented Apr 5, 2024

Very welcome!
I'd like to ask again for a new release please ! :-)

@fxwiegand
Copy link
Contributor

Very welcome! I'd like to ask again for a new release please ! :-)

Yep I'll try to make it happen asap. I don't have admin rights so I cannot git commit --allow-empty -m "chore: release 0.42.2" -m "Release-As: 0.42.2" on the main branch to force release-please to Create a new PR.

@martin-g
Copy link
Contributor Author

Friendly ping!

@fxwiegand
Copy link
Contributor

fxwiegand commented Apr 10, 2024

Friendly ping!

On it thx!

Edit: And the release is out!

@martin-g
Copy link
Contributor Author

Thank you, @fxwiegand !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants