Add wasm dev-deps using CI script#2104
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Oct 6, 2023
Merged
Conversation
We only test WASM in CI using a stable toolchain however because we have a target specific dev-dependencies section the wasm deps get pulled in during MSRV builds - this breaks the MSRV build. Instead of including WASM dev-dependencies in the manifest we can dynamically modify the manifest when running the WASM tests. We do this already to add the `crate-type` section so this is not really that surprising to see in the CI script. Doing so allows us to stop pinning the transitive `syn` dependency also which is included in the dependency graph because of `wasm-bingen-test`.
Member
Author
|
WTF, #2093 passed CI, which means we don't need this. I am not allocating clock cycles to work out why right now. Converting to draft. |
Member
|
I kinda like the idea of doing this anyway since it moves wasm stuff out of our fixed lockfiles. (Their presence there is misleading since we don't actually test WASM using the fixed lockfiles, because wasm-bindgen does not respect them properly, or something. See rust-bitcoin/rust-secp256k1#632 ) |
Member
Author
|
I like the idea of it too, undrafting. |
apoelstra
approved these changes
Oct 6, 2023
sanket1729
approved these changes
Oct 6, 2023
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
ACK 685e510. Removing wasm from lock-files is a win
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only test WASM in CI using a stable toolchain however because we have a target specific dev-dependencies section the wasm deps get pulled in during MSRV builds - this breaks the MSRV build.
Instead of including WASM dev-dependencies in the manifest we can dynamically modify the manifest when running the WASM tests. We do this already to add the
crate-typesection so this is not really that surprising to see in the CI script.Doing so allows us to stop pinning the transitive
syndependency also which is included in the dependency graph because ofwasm-bingen-test.Originally part of #2093