-
Notifications
You must be signed in to change notification settings - Fork 305
Release tracking PR: secp256k1-sys v0.12.0
#865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm sitting in the airport; could not work out right now what has been changed that requires this so I put a TODO in the changelog, seems reasonable since it will be the same changelog for the non-beta release. |
|
All the |
|
@tcharding you need to re-run the vendoring script to increase the version of secp256k1-sys. I think we should bump it to 0.12.0 rather than 0.12.0-beta.0 since we aren't expecting any API changes to -sys and our logic for separating symbol names in the C library doesn't handle suffixes. |
secp256k1-sys v0.12.0
d675c90 to
98264f6
Compare
|
Can you put me out of my misery and tell me exactly how to run the vendor script please? I've managed to just strip the numbers out of the symbols all together. |
|
98264f6 to
cbd0dfb
Compare
|
Where did that commit hash come from? |
|
@tcharding it's the existing commit hash in |
cbd0dfb to
12d9976
Compare
In preparation for release, bump the version, add a changelog entry, and update the lock files, and run the vendor script. Ran script with ./vendor-libsecp.sh 0cdc758a56360bf58a851fe91085a327ec97685a
12d9976 to
cdedca8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK cdedca8; successfully ran local tests
|
Tagged and published. |
|
Also tagged and published 0.32.0-beta.0 of the main crate. |
|
BOOM. We got there in the end huh. |
In preparation for release, bump the version, add a TODO placeholder as a changelog, and update the lock files.