Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Gura support #446

Closed
wants to merge 5 commits into from
Closed

Added Gura support #446

wants to merge 5 commits into from

Conversation

mkvolkov
Copy link

Added support for Gura. Closes issue #245

matthiasbeyer
matthiasbeyer requested changes Jul 29, 2023
View reviewed changes
Copy link
Member

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for continuing!

I am off the grid for approx. The next week, so please expect delays in response.

One question (see review). There might be more, I cannot do in depth reviews now as I am on a train. Either way, thanks again for contributing!

Cargo.toml Outdated Show resolved Hide resolved
matthiasbeyer
matthiasbeyer requested changes Jul 29, 2023
View reviewed changes
src/file/format/mod.rs Outdated Show resolved Hide resolved
src/file/format/mod.rs Outdated Show resolved Hide resolved
src/file/format/mod.rs Show resolved Hide resolved
src/file/format/mod.rs Outdated Show resolved Hide resolved
@polarathene
Copy link
Collaborator

@matthiasbeyer friendly ping as this PR is getting stale (already conflicts raised).

Only one ura remains from your feedback, but it's intentional as it's the file format extension.

@matthiasbeyer
Copy link
Member

Yes this needs a rebase for resolving conflicts.

@polarathene polarathene mentioned this pull request Oct 4, 2023
Open
@polarathene
Copy link
Collaborator

polarathene commented Oct 4, 2023 •
edited
Loading

Yes this needs a rebase for resolving conflicts.

Done #467

@mkvolkov can update their branch here, otherwise my alternative one should be sufficient if they're unresponsive.

@mkvolkov mkvolkov closed this by deleting the head repository Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarathene polarathene polarathene left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkvolkov @polarathene @matthiasbeyer