Repository navigation
Filter ignored linker optimization flag before invoking Zig - #486
Merged
Merged
Conversation
|
Tested on Windows with rustc 1.98.1 and Zig 0.16.0, applied to fcc8f30. The warning is gone for x86_64- and aarch64-unknown-linux-musl, and the release binaries are byte-identical with and without |
messense
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust automatically passes
-Wl,-O1during optimized builds. cargo-zigbuild forwards it tozig cc, which ignores the option and emits a warning.This argument should be filtered to avoid noisy release builds, since the warning doesn't provide any gain whatsoever.
Addresses #483.