Skip to content

add support for macos version suffix - #489

Open
jprochazk wants to merge 1 commit into
rust-cross:mainfrom
jprochazk:support-macos-version-suffix
Open

jprochazk wants to merge 1 commit into
rust-cross:mainfrom
jprochazk:support-macos-version-suffix

Conversation

@jprochazk

Copy link
Copy Markdown

@messense messense left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should also support parsing MACOSX_DEPLOYMENT_TARGET env var and include the version in zig target?

@jprochazk

Copy link
Copy Markdown
Author

I wonder if we should also support parsing MACOSX_DEPLOYMENT_TARGET env var and include the version in zig target?

I was only thinking about the glibc version suffix when implementing this, but when compiling on macOS for an older version, setting that env var is what you'd normally do, so it'd make sense to support it as well.

The issue is what happens if you set both the version suffix and MACOSX_DEPLOYMENT_TARGET. Maybe the --target version suffix shouldn't be supported at all, and only the env var should work? That is the "standard" way to provide the version after all, zig is an outlier here. That being said, --target with version suffix seems nicer to me than the env var.

@messense

messense commented Oct 8, 2026

Copy link
Copy Markdown
Member

Maybe the --target version suffix shouldn't be supported at all, and only the env var should work? That is the "standard" way to provide the version after all, zig is an outlier here.

Sorry for the late reply, was on vacation. This sounds good to me.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for version suffixes for Apple targets

2 participants