Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Possibly new website for rust Dublin #2

Open
wants to merge 62 commits into
base: publish
Choose a base branch
from
Open

feat: Possibly new website for rust Dublin #2

wants to merge 62 commits into from
+9,026 −15,280

Conversation

killianogorman
Copy link

@killianogorman killianogorman commented Jun 9, 2024 •
edited
Loading

This PR represents a comprehensive overhaul of the Rust Dublin website. The updates include a redesigned layout, new pages for sponsorships, enhanced content structure, and improved documentation for contributors.

Major Changes

  • New framework choice: Astro (It's not WASM but it's very good)
  • Redesigned Layout: Implemented a fresh, modern design using Tailwind CSS.
    Improved site navigation and overall user experience.
  • New Pages Added:
    - Sponsorship Page: Detailed information on sponsorship packages, benefits, and application instructions.
    - About Page: Information about Rust Dublin.
    - Talks and Blog Pages: Enhanced layout and design for talks and blog posts.
    - Speaker Pages: Show off a little bit about the wonderful rust Dublin speakers
  • Made a rust programme for checking markdown files for profanity. (Not great)

Contributing

If this PR is merged obviously some changes would need to be made eg.

  • If website is going to be published with github pages using <org_name>.github.io/<repo_name>, Some modifications would need to be made to as according to this Astro Tutorial
  • The home page has a blank square on the right so either a image or graphic
  • Total/partial digitisation of previous talks. This would require changes to src/content/people src/content/talks
  • Metadata is a bit dodgy right now.

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

Thanks 🧡

Thanks so much for anyone that read this PR. I did this over the weekend to test my astro skills.

Note

The current website domain is not pointing to Github pages.

Screenshots

Homepage: Hero
Footer
About Page
Talks
A Sample Talk Page
Speaker Page
image
Code of Conduct Page

@killianogorman
Remove all old website files
fba374d
@killianogorman
Create Home Page
52fef8e
@killianogorman
Merge pull request #1 from killianogorman/new-website
8e6c371 
New website: Add Homepage in astro
@killianogorman
Fix Homepage and Footer Links
33a7e0d
@killianogorman
Merge pull request #2 from killianogorman/new-websiteHomePage-links
d2ac498 
New website: home page & footer links
@killianogorman
Create Readme.md
46d829e
@killianogorman
Merge pull request #3 from killianogorman/Add-Readme
4f1f0fa 
Create Readme.md
@killianogorman
Add a test deployment file
e505e8a
@killianogorman
Create gp.yml
4ae556a
@killianogorman
Update deploy.yml
6246c21
@killianogorman
Update deploy.yml
7fb0610
@killianogorman
Add Astro base to config file
8e41bec
@killianogorman
Merge branch 'publish' of https://github.com/killianogorman/rust-dubl…
6cc721b 
…in-website into publish
@killianogorman
Update deploy.yml
b833a00 
Change Deploy.yml Trigger Branch
@killianogorman
Update and rename gp.yml to build.yml
0241317
@killianogorman
Update workflow files
7073e80
@killianogorman
Add and configure collections and content
1003758
@killianogorman
Update 03.md wording
db6ef23
@killianogorman
Add content and work on Layout
587b4c2
@killianogorman
Create CONTRIBUTING
ccde6a3
@killianogorman
Create pull_request_template.md
64e9685
@killianogorman
Update workflows, sponsors & readme files
7c05491 
Workflows: Removed "paths-ignore"
Sponsors: Added sponsor logos and changed sponsors on website to reflect
Readme: Added Sponsorship inquiry info
@killianogorman
Where in the world is Ferris?
0d4d9e6
@killianogorman
Create CODE_OF_CONDUCT
de5b615
@killianogorman
Rename CODE_OF_CONDUCT to CODE_OF_CONDUCT.md
a5da27b
@killianogorman
update to build
58f4825
@killianogorman
Merge branch 'talks-page' of https://github.com/killianogorman/rust-d…
87ae031 
…ublin-website into talks-page
@killianogorman
Modify Nav,Talks,Code Of Conduct Pages Add About
8126f95
@killianogorman
Merge pull request #4 from killianogorman/talks-page
03267d4 
Add Talks page and other modifications
@killianogorman
Update deploy.yml
b89a8e6
@killianogorman
Creat Blog Config and Add profanity checker
9dedbeb
@killianogorman
Update check.yml
c97422a
@killianogorman
Update Schema of Posts and Talks etc
6cefbfc
@killianogorman
Merge branch 'publish' of https://github.com/killianogorman/rust-dubl…
2d87fd2 
…in-website into publish
@killianogorman
Update ignore file to Include rust builds and create post
3833dc2
@killianogorman
Update check.yml
e23e089
@killianogorman
Change copy
61b80fc
@killianogorman
Merge branch 'publish' of https://github.com/killianogorman/rust-dubl…
739559f 
…in-website into publish
@killianogorman
Update 15.md
8b6b195
@killianogorman
Update check.yml
1139d81
@killianogorman
Update 14.md
d34d871
@killianogorman
Update check.yml
962cc83
@killianogorman
Update 13.md
4aa8c64
@killianogorman
Update check.yml
f6bd977
@killianogorman
Update check.yml
7df1630
@killianogorman
Update 02.md
011f4cf
@killianogorman
Update main.rs
173da92
@killianogorman
Remove old files and update layouts
88f627e
@killianogorman
update nav links and readme
ca1b765
@killianogorman
Update pull_request_template.md
0c974e2
@killianogorman
Update README.md
b4e9eb5
@killianogorman
Add All Talks from Youtube
f721db9
@killianogorman
Merge pull request #5 from killianogorman/add-talks
c32b96a 
Add All Talks from Youtube
@No9
Copy link
Member

No9 commented Jun 9, 2024

Really like the style on this.
Need to review what's involved but I'm in favour of going for a LGTM.
Let's see what the others say too. @codecrunchers @ekarademir @jpastuszek

@codecrunchers
Copy link

Hey, wow, impressive, thanks a million. Only seeing this now, but will have a quick look tomorrow and as @No9 said, give it a LGTM

@bgillespie
Copy link

This looks great! Busy weekend there Killian :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@killianogorman @No9 @codecrunchers @bgillespie