Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement core::error::Error for all error types #180

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

michael-p
Copy link

Closes #179

@thejpster
Copy link
Member

thejpster commented Feb 25, 2025

The new feature needs adding to the CI workflow, but it'll break the matrix because you can't build it with 1.76. I don't have any good ideas on how to fix that right now - happy to hear if you have any.

@michael-p
Copy link
Author

The new feature needs adding to the CI workflow, but it'll break the matrix because you can't build it with 1.76. I don't have any good ideas on how to fix that right now - happy to hear if you have any.

Argh, that's annoying! Sorry, no ideas from my side, except just duplicating the workflow for the core-error feature with Rust 1.81. Do you want me to do that, or would you prefer to just not test this in CI?

@thejpster
Copy link
Member

does https://github.com/orgs/community/discussions/26253#discussioncomment-3250989 help?

I wouldn't want to add something that wasn't being tested in CI, as it'll just break.

@avsaase
Copy link

avsaase commented Mar 8, 2025

You can exclude specific configurations from a matrix job: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymatrixexclude

EDIT: I somehow didn't see the previous comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement core::error::Error
3 participants