-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn repository into workspace and separate the tests #103
base: master
Are you sure you want to change the base?
Turn repository into workspace and separate the tests #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is what I had in mind as well, thanks for going through the work of restructuring! :)
Just a thought: what if we set up the host side test program as a normal bin? I think that could allow a HAL developer to do something like |
This looks like a better solution compared to what we have now, thank you! |
This is over a year old, what happened? |
I believe the desire was lost and it now has a bunch of conflicts. usb-device isn't super well maintained - I review PRs in my spare time, but don't have time to do any active development on it. |
Exactly, @ryan-summers - Rust USB device stuff has been on my "next month or two" list for about two years now... What we have is a good start, but it could definitely use some focused attention. |
Understandable, though. I'll also revert back to "good enough" once my usecase is fulfilled. :/ |
Reading through #100 and #101, here is a PR turning this repository into a workspace. The idea would be that if @ianrrees and @Disasm agree, we could incorporate their device-side testing suite implementations into this repository so that everything is in a single place.
The directory structure would be:
For now I just linked the repositories in the readme like in #101.
This includes the text from #101 as well. I hope that is fine with @ianrrees.
I do not care about the names of the device test folders. Feel free to propose a new one.
Thoughts?
cc: @ryan-summers