Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to make descriptor writing more flexible #64

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

mvirkkunen
Copy link
Collaborator

Adds a method for writing descriptors with an unknown length in a way that's similar to how accepting control transfers works, and a method for writing endpoint descriptors with extra data in the same manner.

Unfortunately the naming is the reverse of control transfers (write_with takes a callback while accept_with takes a buffer), but this way it's compatible.

This would implement both #63 and #46. @Windfisch, if you have an audio driver going, could you test this to see if it's good for your purposes?

@Windfisch
Copy link

Hey @mvirkkunen, thank you for your effort!
This PR works fine for me (though I still need to manually merge in #62 to support larger descriptors ;)).
I also think that the interface is nice to use, so I'm fine :).

@Windfisch
Copy link

@mvirkkunen care to click "merge" on this?

@eldruin eldruin merged commit d1321ae into master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants