-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new cortex-m-interrupt-number crate #488
Open
adamgreig
wants to merge
1
commit into
master
Choose a base branch
from
c-m-in
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
[package] | ||
name = "cortex-m-interrupt-number" | ||
version = "1.0.0" | ||
edition = "2021" | ||
categories = ["embedded", "hardware-support", "no-std"] | ||
description = "Shared trait for Cortex-M interrupt numbers" | ||
keywords = ["arm", "cortex-m", "register", "peripheral"] | ||
license = "MIT OR Apache-2.0" | ||
readme = "README.md" | ||
repository = "https://github.com/rust-embedded/cortex-m" | ||
|
||
[dependencies] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# cortex-m-interrupt-number | ||
|
||
This crate provides the definition of a trait that is shared between | ||
the `cortex-m` crate and all peripheral access crates (PACs) for | ||
Cortex-M microcontrollers. | ||
|
||
The PACs must implement the `InterruptNumber` trait on an enum of possible | ||
interrupts; refer to the `InterruptNumber` [documentation] for more details. | ||
|
||
[documentation]: https://docs.rs/cortex-m-interrupt-number |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
#![no_std] | ||
|
||
/// Trait for enums of external interrupt numbers. | ||
/// | ||
/// This trait should be implemented by a peripheral access crate (PAC) | ||
/// on its enum of available external interrupts for a specific device. | ||
/// Each variant must convert to a u16 of its interrupt number, | ||
/// which is its exception number - 16. | ||
/// | ||
/// # Safety | ||
/// | ||
/// This trait must only be implemented on enums of device interrupts. Each | ||
/// enum variant must represent a distinct value (no duplicates are permitted), | ||
/// and must always return the same value (do not change at runtime). | ||
/// | ||
/// These requirements ensure safe nesting of critical sections. | ||
pub unsafe trait InterruptNumber: Copy { | ||
/// Return the interrupt number associated with this variant. | ||
/// | ||
/// See trait documentation for safety requirements. | ||
fn number(self) -> u16; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change? What does cargo-semver-checks say? I'd have assumed it was the same trait exported with the same name, so it was OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I'll try and do some tests to check. The main scenarios I'm interested in are: