Make Vec::as_mut_slice public #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandudey
force-pushed
the
jeandudey/mut_slice
branch
from
dd28498
to
bfad0f6
Compare
newAM
previously approved these changes
Oct 30, 2023
|
@jeandudey can you rebase for the changelog update, or allow maintainers write access so I can do it for you? |
jeandudey
force-pushed
the
jeandudey/mut_slice
branch
from
bfad0f6
to
b673a24
Compare
Signed-off-by: Jean-Pierre De Jesus DIAZ <[email protected]>
jeandudey
force-pushed
the
jeandudey/mut_slice
branch
from
b673a24
to
29954b4
Compare
|
@newAM I've rebased the branch to fix the change log conflict |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already available through
DerefMutso making it public doesn't do any harm and makes using slice mut methods a little bit clearer. For example:(&mut s[..]).get_mut(i)vss.as_mut_slice().get_mut(i)