-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add embedded_dma
feature
#362
base: main
Are you sure you want to change the base?
Conversation
e73b851
to
e0289a4
Compare
|
de6c859
to
0465cce
Compare
CI is fixed: |
the impl for
because you can move the vec without calling any |
ReadBuffer implemented for I don't understand ReadBuffer requirements, you can give an example of type, which can implement ReadBuffer safely? P.S. Rebased. |
0465cce
to
cc0f541
Compare
No, ReadBuffer is implemented for types that deref to ie it's implemented for things like |
From
I think that it is not valid, because StableDeref provides some of
|
I think the So it's not sound to implement the traits for |
Box<[T; N]> implements I think than |
cc0f541
to
aa23bce
Compare
Requirements of
Probably need to add "and buffer is not moved" here. Additional requirements of
Taking into account previous requirements it is enough. The
Thus the Thus I consider that we should implement |
I added
embedded_dma
feature to one can sendVec
,pool::object::Object<Vec>
andpool::boxed::Box<Vec>
to embedded DMA as read/write buffers.It allows to use
Vec
with embedded DMA of HAL crates, for example stm32f4xx_hal::dma::Transfer.Unfortunately there is a issue that does not allow to implement embedded_dma::WriteBuffer and embedded_dma::ReadBuffer transparently. Thus it requires optional
embedded_dma
dependency now.