Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IndexMap entry API, fix CI. #402

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Fix IndexMap entry API, fix CI. #402

merged 4 commits into from
Oct 31, 2023

Commits on Oct 31, 2023

  1. indexmap: use correct index when inserting through entry api 

    When inserting using the entry API and the robin-hood case is hit,
we currently return using the incorrect index, which in turn
returns a reference to the wrong entry in the map, causing
undefined behaviour in the API.
    @shaunbennett @Dirbaio
    shaunbennett authored and Dirbaio committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a4bfe3e View commit details
    Browse the repository at this point in the history

  2. indexmap: add another previously-failing assert.

    @Dirbaio
    Dirbaio committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    92b72b1 View commit details
    Browse the repository at this point in the history

  3. Fix CI.

    @Dirbaio
    Dirbaio committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2d16444 View commit details
    Browse the repository at this point in the history

  4. ci: add test, simplify a bit.

    @Dirbaio
    Dirbaio committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2be6a9a View commit details
    Browse the repository at this point in the history