deps: make stable_deref_trait an optional dependency
#409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmsyn
force-pushed
the
deps/optional-stable-deref-trait
branch
2 times, most recently
from
bd4a9f3
to
2720567
Compare
|
I think this can also be excluded on aarch64: Line 31 in 9feb664 |
Should I also remove the associated constant and |
newAM
requested changes
Nov 12, 2023
rmsyn
force-pushed
the
deps/optional-stable-deref-trait
branch
2 times, most recently
from
638a90d
to
3859b62
Compare
Configures the `stable_deref_trait` to only be included for `arm_llsc` and `target_arch = "x86"` platforms. This is because the dependency is only used for the `pool` module, and the `pool` module is only used on the above platforms. Reduces the dependency graph for all other platforms.
rmsyn
force-pushed
the
deps/optional-stable-deref-trait
branch
from
3859b62
to
22745be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures the
stable_deref_traitto only be included forarm_llscandtarget_arch = "x86"platforms. This is because the dependency is only used for thepoolmodule, and thepoolmodule is only used on the above platforms.Reduces the dependency graph for all other platforms.