Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: make stable_deref_trait an optional dependency #409

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

rmsyn
Copy link
Contributor

@rmsyn rmsyn commented Nov 12, 2023

Configures the stable_deref_trait to only be included for arm_llsc and target_arch = "x86" platforms. This is because the dependency is only used for the pool module, and the pool module is only used on the above platforms.

Reduces the dependency graph for all other platforms.

@rmsyn rmsyn force-pushed the deps/optional-stable-deref-trait branch 2 times, most recently from bd4a9f3 to 2720567 Compare November 12, 2023 19:57
@newAM
Copy link
Member

newAM commented Nov 12, 2023

I think this can also be excluded on aarch64:

if !target.starts_with("aarch64") {

@rmsyn
Copy link
Contributor Author

rmsyn commented Nov 12, 2023

I think this can also be excluded on aarch64

Should I also remove the associated constant and compile_probe function?

Cargo.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rmsyn rmsyn force-pushed the deps/optional-stable-deref-trait branch 2 times, most recently from 638a90d to 3859b62 Compare November 13, 2023 01:44
Configures the `stable_deref_trait` to only be included for `arm_llsc`
and `target_arch = "x86"` platforms. This is because the dependency is
only used for the `pool` module, and the `pool` module is only used on
the above platforms.

Reduces the dependency graph for all other platforms.
@rmsyn rmsyn force-pushed the deps/optional-stable-deref-trait branch from 3859b62 to 22745be Compare November 13, 2023 02:03
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@newAM newAM added this pull request to the merge queue Nov 13, 2023
Merged via the queue into rust-embedded:main with commit ee14cda Nov 13, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants