Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI. #455

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Fix CI. #455

merged 2 commits into from
Feb 25, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 19, 2024 •
edited
Loading

  • FromIterator is already in the prelude.
  • Use static_assertions instead of trybuild.

@reitermarkus reitermarkus requested a review from a team February 19, 2024 09:29
Dirbaio
Dirbaio approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL assert_not_impl_any. seems much nicer than the cfail tests that keep breaking. Thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Feb 25, 2024
Merged via the queue into rust-embedded:main with commit f3aa0df Feb 25, 2024
22 checks passed
@reitermarkus reitermarkus deleted the fix-ci branch February 27, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reitermarkus @Dirbaio