Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Vec::drain, as_(mut_)view on the *Inner types, generic over Storage #500

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement Vec::drain, as_(mut_)view on the *Inner types, generic over Storage #500

wants to merge 4 commits into from

Commits on Jul 3, 2024

  1. Vec: implement drain, as_(mut_)view on VecInner, generic over S… 

    …torage`

This makes `drain` usable in the context of an implementation generic over the storage
This also makes it possible to get a `VecView` in this same context

This could also be a way to "de-monomorphize" all the implementations of the `Inner` structs:

We could make all implementation define an inner function that is over a `View` type, and start the
implementation with `this = self.as_(mut_)view`, maybe for binary size and compilation time benefits
    @sosthene-nitrokey
    sosthene-nitrokey committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4102ceb View commit details
    Browse the repository at this point in the history

  2. Genericise as_(mut)view for all containers

    @sosthene-nitrokey
    sosthene-nitrokey committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    90cd4eb View commit details
    Browse the repository at this point in the history

  3. Fix documentation warning

    @sosthene-nitrokey
    sosthene-nitrokey committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9558598 View commit details
    Browse the repository at this point in the history

  4. Fix compilation on targets without atomics

    @sosthene-nitrokey
    sosthene-nitrokey committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f40513e View commit details
    Browse the repository at this point in the history