feat(indexmap): added get_index, get_index_mut and get_index_of
#525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamburus
force-pushed
the
feature/indexmap/get-index
branch
2 times, most recently
from
ce551be to
6be3e66
Compare
pamburus
changed the title
get_index and get_index_mutget_index, get_index_mut and get_index_of
pamburus
force-pushed
the
feature/indexmap/get-index
branch
from
6be3e66 to
de9e7ac
Compare
Member
|
Thanks for the PR. Could you add tests? |
Contributor
Author
|
The tests are in the doc comments and they are passing. |
reitermarkus
reviewed
Apr 6, 2025
reitermarkus
previously approved these changes
Apr 6, 2025
Member
reitermarkus
left a comment
reitermarkus
left a comment
There was a problem hiding this comment.
I'd say the doc tests are enough.
reitermarkus
force-pushed
the
feature/indexmap/get-index
branch
from
1a6d5e2 to
aef5a48
Compare
reitermarkus
force-pushed
the
feature/indexmap/get-index
branch
from
aef5a48 to
df33331
Compare
reitermarkus
approved these changes
Apr 6, 2025
Member
|
Thanks, @pamburus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
get_index,get_index_mutandget_index_ofmethods toIndexMap.See corresponding get_index, get_index_mut and get_index_of in the indexmap crate.
Related pull requests:
truncate#526