Do not list dependency packages by MetadataCommand #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
reviewed
Jan 8, 2024
@fitzgen, just pushed a commit with a failing test case that is fixed by my change. |
kdarkhan
commented
Jan 8, 2024
| assert!(project.fuzz_cargo_toml().is_file()); | ||
| let cargo_toml = fs::read_to_string(project.fuzz_cargo_toml()).unwrap(); | ||
| let expected_dependency_attrs = | ||
| &format!("[dependencies.{name}]\npath = \"..\"", name = project_name); |
There was a problem hiding this comment.
Based on my tests, CargoMetadata crate calls cargo metadata with or without --no-deps.
When called without --no-deps, the result contains all packages including dependency packages which are sorted alphabetically. In order to create a failing example, I had to create a sample cargo project which has the name alphabetically greater than one of its dependencies (project_with_some_dep > matches).
When following `cargo-fuzz` tutorial at https://rust-fuzz.github.io/book/cargo-fuzz/tutorial.html, after executing `cargo fuzz init`, `fuzz/Cargo.toml` contains entry `[dependencies.matches]` instead of `[dependencies.url]`. This is caused by `MetadataCommand` listing dependency packages in addition to main packages which is not desired. This does work as expected if result of `MetadataCommand` contains the first package as the non-dep package but that does not seem to work all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following
cargo-fuzztutorial athttps://rust-fuzz.github.io/book/cargo-fuzz/tutorial.html, after executing
cargo fuzz init,fuzz/Cargo.tomlcontains entry[dependencies.matches]instead of[dependencies.url]. This is caused byMetadataCommandlisting dependency packages in addition to main packages which is not desired.Current implementation does work as expected if result of
MetadataCommandcontains the first package as the non-dep package but that does not seem to work all the time.