Deprecate tree_fold1
for tree_reduce
#895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
tree_fold1
should have been deprecated fortree_reduce
at the same timefold1
was deprecated forreduce
.With this deprecation, we will be able to remove
tree_fold1
andfold1
at the same time and close that chapter once and for all.@scottmcm Do you have an objection on this?
PS: I wish I had thought of this but no, thanks reddit.