Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DoubleEndedIterator for ProcessResults #910

Conversation

shepmaster
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (6814180) to head (0227457).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   94.38%   94.43%   +0.04%     
==========================================
  Files          48       48              
  Lines        6665     6829     +164     
==========================================
+ Hits         6291     6449     +158     
- Misses        374      380       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Philippe-Cholet Philippe-Cholet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I appreciate the update on specialization tests.

However, this leads to a change in meaning. That way, the first error encountered is not necessarily the first in the iterator order. I know that's the all point but I'm unsure about such change.
We can it.rev().process_results(..) if we only need it in reverse so this change only matters when we need both iteration sides. Do you have an example?

EDIT: I see you are the original author of process_results, thanks!

Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

As for the DoubleEndedIterator: I think it's fine to stop with another error.

As for the use cases: try_rfold might be specialized for the underlying iterator.

@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Apr 9, 2024
Merged via the queue into rust-itertools:master with commit 1c5d5cd Apr 9, 2024
13 checks passed
@Philippe-Cholet Philippe-Cholet added this to the next milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants