Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not implement ZipEq::fold (and change test) #915

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

kinto-b
Copy link
Contributor

@kinto-b kinto-b commented Apr 15, 2024

Relates to #755.

I can't really think of a better way to implement this, but it still yields a regression :(

cargo bench --bench specializations "zip_eq/fold"

zip_eq/fold             time:   [509.89 ns 510.95 ns 512.02 ns]
                        change: [+4.8744% +5.1665% +5.4970%] (p = 0.00 < 0.05)
                        Performance has regressed.

Copy link
Member

@Philippe-Cholet Philippe-Cholet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I did specialize the folds that felt the most promising to me but I thought this would be a win.

src/zip_eq_impl.rs Outdated Show resolved Hide resolved
tests/zip.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (6814180) to head (2e6c570).
Report is 48 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
+ Coverage   94.38%   94.42%   +0.03%     
==========================================
  Files          48       48              
  Lines        6665     6837     +172     
==========================================
+ Hits         6291     6456     +165     
- Misses        374      381       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Philippe-Cholet Philippe-Cholet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changes, if you could squash commits.

tests/quick.rs Outdated Show resolved Hide resolved
src/zip_eq_impl.rs Outdated Show resolved Hide resolved
@Philippe-Cholet Philippe-Cholet added this to the next milestone Apr 15, 2024
Copy link
Member

@Philippe-Cholet Philippe-Cholet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Philippe-Cholet Philippe-Cholet changed the title Implement ZipEq::fold Do not implement ZipEq::fold (and change test) Apr 15, 2024
@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue Apr 15, 2024
Merged via the queue into rust-itertools:master with commit 5be2e8d Apr 15, 2024
11 checks passed
@kinto-b
Copy link
Contributor Author

kinto-b commented Apr 15, 2024

@Philippe-Cholet pleasure, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants