-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not implement ZipEq::fold
(and change test)
#915
Do not implement ZipEq::fold
(and change test)
#915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I did specialize the fold
s that felt the most promising to me but I thought this would be a win.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 94.38% 94.42% +0.03%
==========================================
Files 48 48
Lines 6665 6837 +172
==========================================
+ Hits 6291 6456 +165
- Misses 374 381 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After changes, if you could squash commits.
f0eeb0d
to
2e6c570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
ZipEq::fold
ZipEq::fold
(and change test)
@Philippe-Cholet pleasure, thank you :) |
Relates to #755.
I can't really think of a better way to implement this, but it still yields a regression :(