Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert_equal: fix clippy::default_numeric_fallback #932

Merged
merged 1 commit into from
May 14, 2024
Merged

assert_equal: fix clippy::default_numeric_fallback #932

merged 1 commit into from
May 14, 2024

Commits on May 14, 2024

  1. assert_equal: fix clippy::default_numeric_fallback 

    Type of `i` defaults to `i32` when `usize` should be used.
It's only a problem if this function is called with two iterators longer than `i32::MAX`. It seems unlikely to me but who knows?
`i32` should not be the default integer type in the library. `usize` would have more sense so I add the lint as warning (for the library only, it's okay in tests and benchmarks).
    @Philippe-Cholet
    Philippe-Cholet committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fa94ba1 View commit details
    Browse the repository at this point in the history