Add note about Result to find_or_last and find_or_first
#984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phimuemue
reviewed
Aug 7, 2024
We can use them where needed, otherwise elide them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #984 +/- ##
==========================================
- Coverage 94.38% 94.30% -0.08%
==========================================
Files 48 49 +1
Lines 6665 6712 +47
==========================================
+ Hits 6291 6330 +39
- Misses 374 382 +8 ☔ View full report in Codecov by Sentry. |
axelkar
force-pushed
the
find_or_result_docs
branch
from
a781f88
to
225494e
Compare
Merged
phimuemue
force-pushed
the
find_or_result_docs
branch
from
225494e
to
c40ead8
Compare
axelkar
force-pushed
the
find_or_result_docs
branch
from
c40ead8
to
b96e72d
Compare
phimuemue
reviewed
Aug 23, 2024
axelkar
force-pushed
the
find_or_result_docs
branch
from
b96e72d
to
52a9c4a
Compare
phimuemue
requested changes
Aug 24, 2024
auto-merge was automatically disabled
August 24, 2024 21:25
Head branch was pushed to by a user without write access
axelkar
force-pushed
the
find_or_result_docs
branch
from
52a9c4a
to
4313499
Compare
|
Thanks. |
phimuemue
approved these changes
Aug 26, 2024
Merged
via the queue into
rust-itertools:master
with commit Aug 26, 2024
91f9618
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GH-983
@phimuemue
Is the wording okay? What about the explicit type definition?