-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about Result to find_or_last
and find_or_first
#984
Conversation
We can use them where needed, otherwise elide them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #984 +/- ##
==========================================
- Coverage 94.38% 94.30% -0.08%
==========================================
Files 48 49 +1
Lines 6665 6712 +47
==========================================
+ Hits 6291 6330 +39
- Misses 374 382 +8 ☔ View full report in Codecov by Sentry. |
a781f88
to
225494e
Compare
225494e
to
c40ead8
Compare
c40ead8
to
b96e72d
Compare
b96e72d
to
52a9c4a
Compare
Head branch was pushed to by a user without write access
52a9c4a
to
4313499
Compare
Thanks. |
91f9618
See GH-983
@phimuemue
Is the wording okay? What about the explicit type definition?