Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change an instance of default_features in Cargo.toml to default-features #985

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

LikeLakers2
Copy link
Contributor

As per cargo itself when running a cargo build:

default_features is deprecated in favor of default-features and will not work in the 2024 edition (in the quickcheck dependency)

Since default_features and default-features work the same, this should not change any functionality beyond removing the warning when building itertools. To be sure, however, I ran cargo test after the change, and all tests passed.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (6814180) to head (3d7037e).
Report is 127 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   94.38%   94.35%   -0.04%     
==========================================
  Files          48       49       +1     
  Lines        6665     6768     +103     
==========================================
+ Hits         6291     6386      +95     
- Misses        374      382       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jswrenn jswrenn added this pull request to the merge queue Oct 22, 2024
Merged via the queue into rust-itertools:master with commit 5d4056b Oct 22, 2024
13 of 14 checks passed
@LikeLakers2 LikeLakers2 deleted the update-cargo-toml branch October 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants