Skip to content

Commit

Permalink
Auto merge of rust-lang#130961 - tgross35:f16-x86-apple, r=<try>
Browse files Browse the repository at this point in the history
Enable `f16` tests on x86 Apple platforms

These were disabled because Apple uses a special ABI for `f16`. `compiler-builtins` merged a fix for this in [1], which has since propagated to rust-lang/rust. Enable tests since there should be no remaining issues on these platforms.

[1]: rust-lang/compiler-builtins#675

try-job: x86_64-apple-1
try-job: x86_64-apple-2
  • Loading branch information
bors committed Sep 27, 2024
2 parents fa724e5 + 43e4c07 commit f78b7e7
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions library/std/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ fn main() {
("arm64ec", _) => false,
// MinGW ABI bugs <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115054>
("x86_64", "windows") => false,
// Apple has a special ABI for `f16` that we do not yet support
// FIXME(builtins): fixed by <https://github.com/rust-lang/compiler-builtins/pull/675>
("x86" | "x86_64", _) if target_vendor == "apple" => false,
// Missing `__gnu_h2f_ieee` and `__gnu_f2h_ieee`
("powerpc" | "powerpc64", _) => false,
// Missing `__gnu_h2f_ieee` and `__gnu_f2h_ieee`
Expand All @@ -116,10 +113,9 @@ fn main() {
("riscv32" | "riscv64", _) => false,
// Most OSs are missing `__extendhfsf` and `__truncsfhf`
(_, "linux" | "macos") => true,
// Almost all OSs besides Linux and MacOS are missing symbols until compiler-builtins can
// be updated. <https://github.com/rust-lang/rust/pull/125016> will get some of these, the
// next CB update should get the rest.
_ => false,
// TODO: only for testing, this line will wind up changed as part of
// <https://github.com/rust-lang/rust/pull/129385>.
_ => true,
};

let has_reliable_f128 = match (target_arch.as_str(), target_os.as_str()) {
Expand Down

0 comments on commit f78b7e7

Please sign in to comment.