Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Margin
was being utilized for a wholeMessage
when it really should be perSnippet
, since that is what is displayed together.Margin
should also be calculated byannotate-snippets
and not passed in, as we know how to figure everything out.To fix these problems, this PR does the following:
Snippet
'sDisplayLine
s together into aDisplaySet
so all lines to be rendered for aSnippet
are kept togetherDisplayLine
, so they can reference information about the line. This will also help us in the future to be able to fold annotations into one line where possible, as well as other future rendering improvementsMargin
for eachDisplaySet
is created internally, allowing for better formattingMargin
with the ability to pass in onlycolumn_width
, so users can easily specify it without setting all ofMargin
Breaking changes:
Margin
is now privatecolumn_width
and not all ofMargin
as we now handle it internally