feat: make Level::span generic over RangeBounds

[SamWilsn]

No description provided.

[SamWilsn]

Hm, I'm wondering if this needs to be Bound::Exclusive(ann.exclusive_end(foo) - new_start) instead.

[Muscraft]

Do you mind if I ask what the reasoning behind this change was?

[SamWilsn]

Do you mind if I ask what the reasoning behind this change was?

Not at all! I tried to use a 0..=3 range, and noticed span wasn't generic over the types of ranges. This pull request improves the ergonomics of the span function so that it more closely matches the API of str.

[epage]

Could you expand on what your use case is? We expect this to be used programmatically which would generally be done with one range type and the current is most flexible.

[SamWilsn]

There is no use case. This is just an ergonomic upgrade. It allows the following ranges that weren't allowed before:

Level::Error.span(2..4);    // Range (what you support now)
Level::Error.span(2..=4);   // RangeInclusive
Level::Error.span(..4);     // RangeTo
Level::Error.span(..=4);    // RangeToInclusive
Level::Error.span(2..);     // RangeFrom
Level::Error.span(..);      // RangeFull

If this adds too much complexity, feel free to close. I don't mind.

[epage]

What i want to understand from the use case is how you are creating the spans. Are you hand writing them? If so, why?

[SamWilsn]

I have a lint that always starts from the beginning of a line, which is probably the only decent example I have.

[Muscraft]

Without a more specific use case, I am not sure if the added complexity is worth it at this time. I think this is something to look into more as the library progresses.

That said, I am going to close this for now, but I greatly appreciate the PR.