Migrate GitHub Pages deployment away from the static-websites action #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As suggested from Miikka we need to change the settings of the repo immediately before merge the PR |
9 tasks
|
Looks good to me, thanks 🙌 |
|
Hey @nrc, can the infra team take care of this? |
That would be great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: rust-lang/simpleinfra#597
This PR migrates the deployment to GitHub pages away from the custom
static-websitesGHA action to the official actinos/upload-github-pages-artifact and actions/deploy-pages actions.For this to work, this repo needs to be configured to use GitHub Actions as the source for Pages.
I tested this in my own fork and it seemed to work (with the
if:conditions commented out as they would prevent the interesting parts from running).