Post: The wasm32-wasip2 target has reached tier 2 support (attempt 2) #1433
Merged
Mark-Simulacrum merged 3 commits intomasterfrom Nov 26, 2024
Merged
Post: The wasm32-wasip2 target has reached tier 2 support (attempt 2) #1433Mark-Simulacrum merged 3 commits intomasterfrom
wasm32-wasip2 target has reached tier 2 support (attempt 2) #1433Mark-Simulacrum merged 3 commits intomasterfrom
Conversation
alexcrichton
approved these changes
Nov 21, 2024
Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>
Member
Author
|
I think? I'm not quite sure who I should be tagging here |
Mark-Simulacrum
approved these changes
Nov 25, 2024
Member
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
Modulo moving the date (maybe today?) this seems fine to me. We have a release this Thursday (1.83) so would prefer to avoid that date.
Mark-Simulacrum
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-submission of #1391, which we had unfortunately had to unpublished soon after release as documented in #1397. We've validated that the
wasm32-wasip2target now actually installs in Rust 1.82, which means we can now re-publish the post.I've made some minor tweaks to the wording in the post - most notably rewritten it to no longer be in the future tense (the target is tier 2, not will be in the future). So we should probably still have an extra pair of eyes on it to double check it. But otherwise I think this should be good to go.
I've set the date it as Thursday 2024-11-21 - I don't believe that should conflict with any other posts, but let me know if we want to change that.
cc/ @alexcrichton
Rendered