Add rustdoc performance blog post#760
Conversation
|
👍 |
|
Oh hold on - @bugadani mentioned that we should probably mention the actual performance PRs, which are caching intra-doc links and not looking for blanket impls. Let's hold off on merging until then. |
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
- Add PRs targeted at intra-doc link performance - Be more environmentally friendly
|
Ok, this is ready for review. |
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Looks good, might need someone to go through and make copy edits
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
Co-authored-by: Dániel Buga <bugadani@gmail.com>
|
|
||
| ## Errata | ||
|
|
||
| An earlier version of the blog post described the section on slimming `doctree` as "Burning down |
There was a problem hiding this comment.
That makes me sad. It was a funny pun. :'(
camelid
left a comment
camelid
left a comment
There was a problem hiding this comment.
Great blog post! I have some comments that are mostly typographical nits and also a typo or two :)
Some of them are stylistic choices, so they're not a big deal, but I wanted to suggest possible alternatives to see what you think.
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2021-01-15-rustdoc-performance-improvements.md
Outdated
Show resolved
Hide resolved
|
@camelid I've given you write access to my fork, feel free to make all the edits you want. I'll try to address the review comments at some point but I may not get around to it today. |
| 1. Rustdoc: Cache resolved links [#77700](https://github.com/rust-lang/rust/pull/77700) | ||
|
|
||
| This does what it says in the title. In particular, this sped up the time to generate intra-doc | ||
| links for `stm32h7xx` by a whopping [90,000%]. [**@bugadani**](https://github.com/bugadani) did an |
There was a problem hiding this comment.
Just realized, 90x =/= 90000%. I think this is a zero off :)
There was a problem hiding this comment.
The comment this links to seems to show an 82x speedup. Maybe we should just say "by a whopping 82x"? Or "this was an 82x speedup"?
There was a problem hiding this comment.
a huge percentage looks alot better tho 🤓
7 participants
r? @Manishearth
cc @GuillaumeGomez