Skip to content

fix: minor typo in chapter 17 documentation#4324

Closed
MathRdt wants to merge 1 commit intorust-lang:mainfrom
MathRdt:fix/ch17-typos
Closed

fix: minor typo in chapter 17 documentation#4324
MathRdt wants to merge 1 commit intorust-lang:mainfrom
MathRdt:fix/ch17-typos

Conversation

@MathRdt
Copy link
Copy Markdown

@MathRdt MathRdt commented Apr 3, 2025

No description provided.

@neurolag
Copy link
Copy Markdown

There's one more in this chapter here:

That’s a lot to absorb! To really understand it, let’s we dive a little further

I think it might make sense to fix this typo in this PR as well.

@MathRdt
Copy link
Copy Markdown
Author

MathRdt commented Apr 11, 2025

There's one more in this chapter here:

That’s a lot to absorb! To really understand it, let’s we dive a little further

I think it might make sense to fix this typo in this PR as well.

You are right, This sentence seemed weird to me too, but, as english is not my native language, I didn't know if this was a valid sentence or not.
I removed the "we" to reformulate it in a more obvious way.

@neurolag
Copy link
Copy Markdown

We're in the same boat, then, I guess
but I'm 90% sure it's a typo.

@nixxo
Copy link
Copy Markdown
Contributor

nixxo commented Aug 9, 2025

Regarding the WE "typo", the author of the book is telling the student, "we are doing this thing together...". Without the WE is correct as well, just a little more informal. It's not a typo, imho, just a personal touch from the author of the sentence.

The second one I agree is a typo.

@neurolag
Copy link
Copy Markdown

neurolag commented Aug 10, 2025

aaah fair - I wasn't exactly sure "let us we" is proper English

@carols10cents
Copy link
Copy Markdown
Member

Hi, sorry, the files in the nostarch directory aren't what's used for the book-- they're snapshots at a particular point in time that correspond to the print versions, as explained in the comment at the top of the file you edited. This was fixed in the src versions in ba1646d but I hadn't updated the snapshot. Thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants