Ch 21.02 - listings missing required code#4350
Open
rickrain wants to merge 7 commits intorust-lang:mainfrom
Open
Ch 21.02 - listings missing required code#4350rickrain wants to merge 7 commits intorust-lang:mainfrom
rickrain wants to merge 7 commits intorust-lang:mainfrom
Conversation
Contributor
Author
|
It seems that the CI is failing because my implementation didn't have the curly brackets in my closure and instead just processed let thread = thread::spawn(|| {
receiver;
});my code was let thread = thread::spawn(||
receiver
);This seemed to have happened when I ran Oddly, when I run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates listings
21-17and21-18to show changes that were necessary to theWorkerstruct.In listing
21-17, unless you also update the type for theWorker::threadfield, you will get compiler errors about mismatched types, in addition to, the ownership errors that were expected. Since these additional errors were not mentioned in the text, the reader should see that the struct needed updating too. It's clear from the text that the intent was to focus on the ownership/borrowing errors - this change accomplishes that.Similarly, in listing
21-18, the type for theWorker::threadfield needs to be updated with the new smart pointer declaration, otherwise it won't compile. I didn't add any text to the markdown for this change, since the explanation from21-17is already understood.