Skip to content

Canonicalize issue links in rollup PR body #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kobzol merged 1 commit into from
Jan 7, 2026
Merged

Canonicalize issue links in rollup PR body #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions src/github/rollup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,13 +327,23 @@ async fn create_rollup(

let mut body = "Successful merges:\n\n".to_string();
for pr in &successes {
body.push_str(&format!(" - #{} ({})\n", pr.number.0, pr.title));
body.push_str(&format!(
" - {}#{} ({})\n",
gh_client.repository(),
pr.number.0,
pr.title
));
}

if !failures.is_empty() {
body.push_str("\nFailed merges:\n\n");
for pr in &failures {
body.push_str(&format!(" - #{} ({})\n", pr.number.0, pr.title));
body.push_str(&format!(
" - {}#{} ({})\n",
gh_client.repository(),
pr.number.0,
pr.title
));
}
}
body.push_str("\nr? @ghost");
Expand Down Expand Up @@ -506,13 +516,13 @@ mod tests {
insta::assert_snapshot!(repo.lock().get_pr(6).description, @"
Successful merges:

- #2 (Title of PR 2)
- #3 (Title of PR 3)
- #5 (Title of PR 5)
- rust-lang/borstest#2 (Title of PR 2)
- rust-lang/borstest#3 (Title of PR 3)
- rust-lang/borstest#5 (Title of PR 5)

Failed merges:

- #4 (Title of PR 4)
- rust-lang/borstest#4 (Title of PR 4)

r? @ghost

Expand Down Expand Up @@ -547,12 +557,12 @@ mod tests {
insta::assert_snapshot!(repo.lock().get_pr(5).description, @"
Successful merges:

- #2 (Title of PR 2)
- #4 (Title of PR 4)
- rust-lang/borstest#2 (Title of PR 2)
- rust-lang/borstest#4 (Title of PR 4)

Failed merges:

- #3 (Title of PR 3)
- rust-lang/borstest#3 (Title of PR 3)

r? @ghost

Expand Down Expand Up @@ -585,8 +595,8 @@ mod tests {
insta::assert_snapshot!(repo.lock().get_pr(4).description, @"
Successful merges:

- #2 (Title of PR 2)
- #3 (Title of PR 3)
- rust-lang/borstest#2 (Title of PR 2)
- rust-lang/borstest#3 (Title of PR 3)

r? @ghost

Expand Down Expand Up @@ -623,10 +633,10 @@ mod tests {
insta::assert_snapshot!(repo.lock().get_pr(6).description, @"
Successful merges:

- #3 (Title of PR 3)
- #4 (Title of PR 4)
- #2 (Title of PR 2)
- #5 (Title of PR 5)
- rust-lang/borstest#3 (Title of PR 3)
- rust-lang/borstest#4 (Title of PR 4)
- rust-lang/borstest#2 (Title of PR 2)
- rust-lang/borstest#5 (Title of PR 5)

r? @ghost

Expand Down Expand Up @@ -654,8 +664,8 @@ mod tests {
insta::assert_snapshot!(repo.lock().get_pr(4).description, @"
Successful merges:

- #2 (Title of PR 2)
- #3 (Title of PR 3)
- rust-lang/borstest#2 (Title of PR 2)
- rust-lang/borstest#3 (Title of PR 3)

r? @ghost

Expand Down