feat(trim-paths): set env CARGO_TRIM_PATHS for build scripts#12900
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 31, 2023
Merged
feat(trim-paths): set env CARGO_TRIM_PATHS for build scripts#12900bors merged 2 commits intorust-lang:masterfrom
CARGO_TRIM_PATHS for build scripts#12900bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-build-scripts
11 tasks
weihanglo
added
Z-trim-paths
Member
Author
|
spurious network error seems like?
https://github.com/rust-lang/cargo/actions/runs/6706964313/job/18224456440?pr=12900#step:5:552 @bors retry |
bors
added
S-waiting-on-bors
epage
reviewed
Oct 31, 2023
epage
reviewed
Oct 31, 2023
weihanglo
force-pushed
the
trim-paths-build-script
branch
from
0c69592 to
32514c3
Compare
epage
reviewed
Oct 31, 2023
epage
approved these changes
Oct 31, 2023
Contributor
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
Feel free to r= me whether you make my suggestion or not.
weihanglo
force-pushed
the
trim-paths-build-script
branch
from
32514c3 to
2915729
Compare
Member
Author
|
@bors r=epage |
Contributor
Contributor
8 tasks
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2023
Update cargo 7 commits in 708383d620e183a9ece69b8fe930c411d83dee27..b4d18d4bd3db6d872892f6c87c51a02999b80802 2023-10-27 21:09:26 +0000 to 2023-10-31 18:19:10 +0000 - refactor(toml): Cleanup noticed on the way to rust-lang/cargo#12801 (rust-lang/cargo#12902) - feat(trim-paths): set env `CARGO_TRIM_PATHS` for build scripts (rust-lang/cargo#12900) - feat: implement RFC 3127 `-Ztrim-paths` (rust-lang/cargo#12625) - docs: clarify config to use vendored source is printed to stdout (rust-lang/cargo#12893) - Improve the margin calculation for the search command's UI (rust-lang/cargo#12890) - Add new packages to [workspace.members] automatically (rust-lang/cargo#12779) - refactor(toml): Decouple parsing from interning system (rust-lang/cargo#12881) r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Set profile options as environment variable
CARGO_TRIM_PATHSfor build scripts.As a follow up of #12625.
How should we test and review this PR?
Docs and test should be pretty straightforward.
Additional information