doc(features): Highlight the non-blocking feature gating technique#13307
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 16, 2024
Merged
doc(features): Highlight the non-blocking feature gating technique#13307bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
We already discussed non-blocking gates but the language makes it sound like it was limited to `config.toml`. Since I haven't been touching that, I had always overlooked that section. This change brings the blocking / non-blocking decision front and center. To support this, the later sections focus more on mechanisms (the gate) rather than on what is being done (new syntax for `cargo-features`). I also feel this makes the content more scannable. This is adapted from what I did for `[lints]` (see rust-lang#12148).
Collaborator
|
r? @weihanglo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-unstable
This was referenced Jan 16, 2024
weihanglo
approved these changes
Jan 16, 2024
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Looks good. Feel free to address nits or r=me.
BTW, by “non-blocking feature gate” does it refer to a feature gate that won't bail out but warn/ignore?
Contributor
Author
Yes. Didn't end up using that term in the PR. |
Contributor
Author
|
nits addressed @bors r=weihanglo |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2024
Update cargo 2 commits in 1cff2ee6b92e0ad3f87c44b70b28f788b2528b3c..1ae631085f01c1a72d05df1ec81f3759a8360042 2024-01-16 16:56:57 +0000 to 2024-01-17 17:26:41 +0000 - fix(json-msg): use pkgid spec in in JSON messages (rust-lang/cargo#13311) - doc(features): Highlight the non-blocking feature gating technique (rust-lang/cargo#13307) r? oli-obk Could you check if this fixes miri build?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2024
Update cargo 2 commits in 1cff2ee6b92e0ad3f87c44b70b28f788b2528b3c..1ae631085f01c1a72d05df1ec81f3759a8360042 2024-01-16 16:56:57 +0000 to 2024-01-17 17:26:41 +0000 - fix(json-msg): use pkgid spec in in JSON messages (rust-lang/cargo#13311) - doc(features): Highlight the non-blocking feature gating technique (rust-lang/cargo#13307) r? oli-obk Could you check if this fixes miri build?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already discussed non-blocking gates but the language makes it sound like it was limited to
config.toml.Since I haven't been touching that, I had always overlooked that section.
This change brings the blocking / non-blocking decision front and center.
To support this, the later sections focus more on mechanisms (the gate) rather than on what is being done (new syntax for
cargo-features).I also feel this makes the content more scannable.
This is adapted from what I did for
[lints](see #12148).