refactor: Remove executor trait#15196
Closed
oriongonza wants to merge 3 commits intorust-lang:masterfrom
Closed
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
A-build-execution
This comment has been minimized.
This comment has been minimized.
Contributor
|
I believe in #11428 we decided to keep the trait since some API users are using it. |
oriongonza
force-pushed
the
refactor/executor
branch
from
80db303 to
3ccef47
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
This salvages the few comments of #[15196](#15196)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there was an
Executortrait that existed but doesn't make much sense now,since it's only implemented by a unit struct, so I simplify this by calling a method directly.
Hopefully this will also bring a minuscule perf gain but more importantly simplify cargo a bit.