Skip to content

Conversation

@weihanglo
Copy link
Member

@weihanglo weihanglo commented Oct 26, 2025

What does this PR try to resolve?

Fixes #14956

How to test and review this PR?

This is done with some test generalization, so that we can test more backend interop in the future when libgit2 support file:// protocol shallow clones.

In the future we should add container tests for at least gitoxide and libgit2 backend to ensure they really work with https protocol

This is a preparation for git backend interop tests
Not a shallow clone test and we've covered it in normal git tests.
Make sure each backend is actually used
The newly added tests also ensure the interop between each backend
@rustbot rustbot added A-git Area: anything dealing with git S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@epage
Copy link
Contributor

epage commented Oct 27, 2025

Unsure if anything in this commit would be relevant: epage@9af85fd

Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if you don't see anything relevant in the commit I shared

View changes since this review

@weihanglo
Copy link
Member Author

Thanks for sharing!

I am a bit lazy to rewrite Git history now. Will do a post-cleanup and cherry pick your changes then :)

@weihanglo weihanglo added this pull request to the merge queue Oct 27, 2025
Merged via the queue into rust-lang:master with commit 8120df7 Oct 27, 2025
25 checks passed
@weihanglo weihanglo deleted the git-shallow branch October 27, 2025 16:30
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 28, 2025
### What does this PR try to resolve?

Cherry-pick some test generalization from
<epage@9af85fd>

See
<#16156 (comment)>

`fetch_dep_then_fetch` is a bit tricky to generalize, so leave it there.

### How to test and review this PR?
bors added a commit to rust-lang/rust that referenced this pull request Oct 29, 2025
Update cargo submodule

11 commits in 344c4567c634a25837e3c3476aac08af84cf9203..6c1b6100343691341b9e76c5acc594e78220f963
2025-10-15 15:01:32 +0000 to 2025-10-28 16:27:52 +0000
- feat(build-analysis): JSONL-based logging infra (rust-lang/cargo#16150)
- feat: support array of any types in Cargo config (rust-lang/cargo#16103)
- test(git): add more fetch-index backend interop  (rust-lang/cargo#16162)
- feat(git): support shallow fetch for Git CLI backend (rust-lang/cargo#16156)
- Fix mdman to not incorrectly strip `<p>` tags (rust-lang/cargo#16158)
- chore(triagebot): enable range-diff and review-changes-since (rust-lang/cargo#16152)
- Avoid specifying which version will change behavior (rust-lang/cargo#16153)
- Make shell completion variables private. (rust-lang/cargo#16144)
- More warning conversions (rust-lang/cargo#16143)
- Bump openssl-src to 300.3.5.4+3.5.4 (rust-lang/cargo#16140)
- build: remove duplicate dependency, consolidate over unicode-ident (rust-lang/cargo#16137)
@rustbot rustbot added this to the 1.93.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-git Area: anything dealing with git

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support shallow fetch through net.git-fetch-with-cli

3 participants