feat(lint): new implicit_minimum_version_req lint
#16321
Merged
+1,686
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-documenting-cargo-itself
Collaborator
weihanglo
commented
Dec 1, 2025
Comment on lines
493
to
496
| --> Cargo.toml:7:[..] | ||
| | | ||
| 7 | bar = { git = '[ROOTURL]/bar', version = "0.1" } | ||
| | [..]^^^^^ |
Member
Author
There was a problem hiding this comment.
Because the redaction of [ROOTURL], we have no control oveer column number, so redact them.
weihanglo
commented
Dec 1, 2025
epage
reviewed
Dec 1, 2025
epage
reviewed
Dec 1, 2025
epage
reviewed
Dec 1, 2025
epage
reviewed
Dec 1, 2025
weihanglo
force-pushed
the
lint-imprecise-version-req
branch
from
7fac520 to
fa31eaf
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
weihanglo
changed the title
implicit_minimum_version_req lint
weihanglo
force-pushed
the
lint-imprecise-version-req
branch
4 times, most recently
from
7ce7163 to
20be772
Compare
epage
reviewed
Dec 8, 2025
epage
reviewed
Dec 8, 2025
epage
reviewed
Dec 8, 2025
epage
reviewed
Dec 8, 2025
weihanglo
force-pushed
the
lint-imprecise-version-req
branch
from
20be772 to
62036ab
Compare
weihanglo
commented
Dec 8, 2025
| return None; | ||
| } | ||
|
|
||
| // This is a lossy suggestion that |
Member
Author
There was a problem hiding this comment.
Highlight that the suggestion is lossy
epage
reviewed
Dec 8, 2025
Add a new `cargo::implicit_minimum_version_req` lint: Only check if dependency has a single caret requirement. All other requirements (multiple, tilde, wildcard) are not linted by this rule, as they usually have significance on what version fields get specified. This currently lints only dependencies with no workspace inheritance.
This has a future performance that version requirments in `[workspace.dependencies]` shoud avoid reparse
weihanglo
force-pushed
the
lint-imprecise-version-req
branch
from
62036ab to
864bf96
Compare
epage
approved these changes
Dec 8, 2025
rustbot
removed
the
S-waiting-on-review
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Dec 9, 2025
`unknown_lints` is special that it analyzes only at package level, and warn if your lint is inherited from workspace. According to the discussion in <rust-lang#16321 (comment)>, we should lint against workspace always plus selected packages. This additionally handles unstable lint gating.
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Dec 9, 2025
`unknown_lints` is special that it analyzes only at package level, and warn if your lint is inherited from workspace. According to the discussion in <rust-lang#16321 (comment)>, we should lint against workspace always plus selected packages. This additionally handles unstable lint gating.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
### What does this PR try to resolve? `unknown_lints` is special that it analyzes only at package level, and warn if your lint is inherited from workspace. According to the discussion in <#16321 (comment)>, we should lint against workspace always plus selected packages. This additionally handles unstable lint gating. ### How to test and review this PR? Two new tests are added to reflect that workspace lints were not analyzed if not inheriting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Add a new
cargo::implicit_minimum_version_reqlint:Only check if dependency has a single caret requirement.
All other requirements (multiple, tilde, wildcard)
are not linted by this rule, as they usually have significance
on what version fields get specified.
Fixes #15577
How to test and review this PR?
implicit_minimum_version_reqlint #16321 (comment)allowbecause this may get people a lot of warnings)implicit_minimum_version_reqlint #16321 (comment)implicit_minimum_version_reqlint #16321 (comment)implicit_minimum_version_reqlint #16321 (comment) suggesting the lowerest bound (adding missing zeros)