Repository navigation
Conversation
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Starting as a draft because I had originally talked about a gap before doing this for transition purposes. At #15931 (comment) I said
#17215 changes things a bit in that people just need to set Even then in #17215, I said
Don't remember why I was still feeling we needed a gap. Could be good to get parts of this in stable to start wider conversations and awareness. |
b50b802 to
d414a2c
Compare
| [RUNNING] `rustc --crate-name foo --edition=2015 src/lib.rs [..]--crate-type lib --emit=[..]link[..] -C debuginfo=2 [..]` | ||
| [RUNNING] `rustc --crate-name foo --edition=2015 src/main.rs [..]--crate-type bin --emit=[..]link[..] -C debuginfo=2 [..]` | ||
| [RUNNING] `rustc --crate-name t1 --edition=2015 tests/t1.rs [..]--emit=[..]link[..] -C debuginfo=2 [..]` | ||
| [RUNNING] `rustc --crate-name foo --edition=2015 src/lib.rs [..]--crate-type lib --emit=[..]link[..] -C debuginfo=line-tables-only [..]` |
There was a problem hiding this comment.
Should we just omit debuginfo value part, in case we change that in the future?
(though unlikely)
|
We had an fcp for the direction but not specific changes |
|
I guess we probably need a benchmark report for why the chosen value. The currently discussions are scattered and not sure which is the final one. (like I remembered Josh proposed opt-level=1 but then say no it didn't help) |
With rust-lang#17215 merged, users can set the new `debug` profile as their default build profile without an MSRV bump and get the same behavior between previous versions of Cargo and those that include this change. There is still the possibility of `opt-level` but that is less certain. For cargo `cargo test --no-run` build+target dir: - master: 3.6G - this PR: 2.9G For bevy `cargo test --no-run` build+target dir: - master: 369G - this PR: 348G Surprised at how much space was taken up: - `build/`: 189G -> 174G - `examples/`: 175G -> 168G (across 364 examples) - `incremental/`: 14G -> 8G Fixes rust-lang#15931
abfabcd to
9fb8531
Compare
|
I've included two examples for disk space savings. https://internals.rust-lang.org/t/feedback-request-performance-improvements-from-reducing-debug-info/21825/9 has a lot of self-reports on build time impact, both full build and incremental. |
a52a817 to
e5f7b22
Compare
What does this PR try to resolve?
With #17215 merged, users can set the new
debugprofile as their default build profile without an MSRV bump and get the same behavior between previous versions of Cargo and those that include this change.For cargo
cargo test --no-runbuild+target dir:For bevy
cargo test --no-runbuild+target dir:Surprised at how much space was taken up:
build/: 189G -> 174Gexamples/: 175G -> 168G (across 364 examples)incremental/: 14G -> 8GFor various reports on the impact on build times for this profile setting, see https://internals.rust-lang.org/t/feedback-request-performance-improvements-from-reducing-debug-info/21825/9
Fixes #15931
How to test and review this PR?
There is still the possibility of
opt-levelbut that is less certain.