Skip to content

refactor(cargo-test-support): remove build.rs - #17638

Merged
epage merged 1 commit into
rust-lang:masterfrom
weihanglo:remove-build-rs
Oct 24, 2026
Merged

epage merged 1 commit into
rust-lang:masterfrom
weihanglo:remove-build-rs

Conversation

@weihanglo

Copy link
Copy Markdown
Member

What does this PR try to resolve?

Inspired by #17637.
We should do it and demonstrate how to.

Notes to reviewers

One small behavior difference is that the NATIVE_ARCH env var was static and determined at compile time, while rustc_host now look at rustc host string. I don't think anyone really cross-compile cargo-test-support though.


🤖 LLM involvement: None

@rustbot rustbot added A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2026
@rustbot

rustbot commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

r? @Muscraft

rustbot has assigned @Muscraft.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Muscraft, @epage, @weihanglo
  • @Muscraft, @epage, @weihanglo expanded to Muscraft, epage, weihanglo
  • Random selection from Muscraft, epage

@epage
epage added this pull request to the merge queue Oct 24, 2026
Merged via the queue into rust-lang:master with commit 0f95863 Oct 24, 2026
32 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2026
@weihanglo
weihanglo deleted the remove-build-rs branch October 24, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testing-cargo-itself Area: cargo's tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants