Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detect family: should detect emscripten as clang, closes #1185 #1186

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix detect family: should detect emscripten as clang, closes #1185 #1186

merged 1 commit into from
Aug 16, 2024

Conversation

meowtec
Copy link
Contributor

@meowtec meowtec commented Aug 16, 2024 •
edited by NobodyXu
Loading

Fixed #1185

NobodyXu
NobodyXu approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@NobodyXu NobodyXu merged commit d3ff011 into rust-lang:main Aug 16, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emcc/em++ are detected as ToolFamily::Msvc
2 participants
@meowtec @NobodyXu