fix finding toolchains when invoked by msbuild #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ChrisDenton could you take a look at this PR please? |
|
Another note is that VSTEL_MSBuildProjectFullPath is also set by VS, so I suppose we could remove VisualStudioDir and just use VSTEL_MSBuildProjectFullPath instead |
This would be my preference. I think this should be kept as simple as possible. Though I wonder, is the |
|
Doesn't seem like it. I dumped the env here #1189 (comment) |
|
Fair enough. So I'd agree using |
ChrisDenton
approved these changes
Sep 6, 2024
russelltg
force-pushed
the
msbuild_from_cmdline
branch
from
8bb266c
to
3b58faf
Compare
|
Thank you russelltg ChrisDenton ! |
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1189 (comment), when invoking msbuild from the commandline
VisualStudioDiris not set.VSTEL_MSBuildProjectFullPathdoes seem to be set reliably, even if it's undocumented....I'm open to alternative fixes here as well. It's possible that we should check that the value of it ends in
.vcxprojas if it's a C# library or something it may not have the proper environment set (I'm rather unsure).