Fix clang-cl treating file as a /U arg.#670
Closed
roblabla wants to merge 1 commit intorust-lang:mainfrom
Closed
Conversation
On MacOS, paths will likely start with /Users, but clang-cl treats /U as an argument, which leads to the source being mistaken for a flag. To avoid this, we can pass -- before the source to ensure argument parsing is disabled.
roblabla
force-pushed
the
fix-clangcl-arg
branch
from
781a769 to
6e3b505
Compare
Contributor
Author
|
This was already previously proposed in https://github.com/alexcrichton/cc-rs/pull/514 I can confirm this works as expected. |
Member
|
#514 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MacOS, paths will likely start with /Users, but clang-cl treats /U
as an argument, which leads to the source being mistaken for a flag. To
avoid this, we can pass -- before the source to ensure argument parsing
is disabled.
Fixes #513